Differential D2345

gic_decode_fdt() fix for interrupts-extended property
ClosedPublic
Actions

Authored by skra on Apr 22 2015, 2:12 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 2:50 AM

	Unknown Object (File)
	Sat, Oct 4, 5:03 PM

	Unknown Object (File)
	Sun, Sep 28, 3:45 PM

	Unknown Object (File)
	Sep 21 2025, 6:08 AM

	Unknown Object (File)
	Sep 20 2025, 2:53 PM

	Unknown Object (File)
	Sep 20 2025, 7:50 AM

	Unknown Object (File)
	Sep 20 2025, 4:01 AM

	Unknown Object (File)
	Sep 20 2025, 1:55 AM

View All 92 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS289548: Only decode fdt data which belongs to the GIC controller.

Summary

An interrupt extended property looks like this:
interrupts-extended = <&gic GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core OMAP4_UART4_RX>;

Every xxx_decode_fdt() should check its compatible property and does not process alien tuples. This patch fixes that for GIC.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

skra updated this revision to Diff 4951.Apr 22 2015, 2:12 PM

skra retitled this revision from to gic_decode_fdt() fix for interrupts-extended property.

skra updated this object.

skra edited the test plan for this revision. (Show Details)

skra added a reviewer: ARM.

skra set the repository for this revision to rS FreeBSD src repository - subversion.

skra added a project: ARM.

Herald added subscribers: imp, andrew. · View Herald TranscriptApr 22 2015, 2:12 PM

Since I'm knee-deep in interrupt stuff today I'm going to commit this one too, with a small change to cache the phandle_t after a successful compatible lookup.

This revision is now accepted and ready to land.Oct 18 2015, 8:22 PM

Closed by commit rS289548: Only decode fdt data which belongs to the GIC controller. (authored by • ian). · Explain WhyOct 18 2015, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

arm/

17 lines

include/

3 lines

Diff 9490

head/sys/arm/arm/gic.c

Loading...

head/sys/arm/include/intr.h

Loading...