Makefile.inc1: simplify handling of ObsoleteFiles

[eadler]

Summary

This is the first step to combining the logic of all the check and delete old targets. These should be generalized to: list of stuff to check for, command to print/remove them, and should rely...

Test Plan

%yes no| make -m .../share/mk delete-old 2>&1 L
%yes no| make -m .../share/mk delete-old-files 2>&1 L
%make -m .../share/mk check-old
%make -m .../share/mk check-old-files

[mat]

Like that ?

Makefile.inc1

1917–1933

delete-check-old-files: .SILENT
        echo ">>> ${PRE_MESSAGE}"
.        for OFILE in ${OLD_FILES}
.                if exists(${DESTDIR}/${OFILE})
.if make(delete-old-files) || make(delete-old)
			chflags noschg "${OFILE}" 2>/dev/null || true; \
		        	rm ${RM_I} "${OFILE}"
.else
			echo ${OFILE}
.endif

.                endif
.        endfor

[mat]

Makefile.inc1

1917–1933

Or maybe

REMOVE_FILE=sh -c 'chflags noschg "$$1" 2>/dev/null || true; \
      rm ${RM_I} "$$1"' --

and then just do ${REMOVE_FILE} ${OFILE}

[eadler]

Makefile.inc1

1917–1933

I didn't know that syntax worked, and is pretty much exactly what I wanted. Thanks!

[eadler]

with mat's help get rid of ugly XXX hack

[eadler]

update other usage of REMOVE_FILE_COMMAND