Page MenuHomeFreeBSD

New port x11/albert: fast and flexible keyboard launcher
ClosedPublic

Authored by jsm on Jan 26 2020, 10:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:53 AM
Unknown Object (File)
Dec 17 2023, 11:40 AM
Unknown Object (File)
Nov 13 2023, 1:40 AM
Unknown Object (File)
Nov 9 2023, 8:44 AM
Unknown Object (File)
Oct 9 2023, 12:39 AM
Unknown Object (File)
Oct 8 2023, 7:40 AM
Unknown Object (File)
Sep 5 2023, 11:59 AM
Unknown Object (File)
Sep 5 2023, 11:58 AM
Subscribers

Details

Summary

New port x11/albert

Albert is a fast and flexible keyboard launcher

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for completing the port! BTW, do you have a plan to submit the patches to upstream?

x11/albert/Makefile
4 ↗(On Diff #67308)

How about using DISTVERSIONPREFIX=v?

13 ↗(On Diff #67308)

Is it possible to use USE=python:3.7+ ?

23 ↗(On Diff #67308)

Is it possible to use USES=compiler:c++14-lang ?

linimon retitled this revision from New port x11/albert to New port x11/albert: fast and flexible keyboard launcher.Jan 26 2020, 3:34 PM

Tested in poudriere {11,12}-{amd64,i386}.

x11/albert/Makefile
8 ↗(On Diff #67310)

One very minor nitpick, we mostly use case sensitive FreeBSD for trademark reasons.

This revision is now accepted and ready to land.Jan 27 2020, 2:51 AM

I'll change my email to jsm@FreeBSD.org prior to commit, if that is ok without a new diff...

In D23367#512798, @jsm wrote:

I'll change my email to jsm@FreeBSD.org prior to commit, if that is ok without a new diff...

That's totally fine. Thanks for working on this again. After this committed, let's:

  1. remove it from https://wiki.freebsd.org/WantedPorts
  2. submit patches to upstream
  3. push upstream have a FreeBSD CI.
This revision was automatically updated to reflect the committed changes.
head/x11/albert/Makefile
13–14

The order is BUILD, then LIB. See Chapter 15. Order of Variables in Port Makefiles.

head/x11/albert/Makefile
13–14

Okay, portlint did not complain. I will take note of it, thanks,

head/x11/albert/Makefile
13–14

portlint is a third party tool that almost never does what it should. It is much easier to learn the few rules in there.