Kill MFILES and find things automatically. It turned out to be only
lightly used. Find the proper .m file when we depend on *_if.[ch]
in the srcs line, with seat-belts for false positive matches.
Details
Details
- Reviewers
jhb - Group Reviewers
manpages - Commits
- rS285068: Kill MFILES and find things automatically. It turned out to be only
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Running lots of finds is perhaps not ideal. Not sure if you want to make find avoid recursing into 'compile' for people doing old-style builds still.
Comment Actions
Better way of finding the .m files, though it introduces implicit
rules for some files.
Comment Actions
arc loves to mess with me by doing all commits, not just the most
recent queue entry. Fix that.
| sys/conf/kmod.mk | ||
|---|---|---|
| 360 ↗ | (On Diff #5075) | This will still do a find for each module (probably N as each time the Makefile is processed for each of clean, obj, depend, install each module Makefile has to run find). Why not let .PATH.m be static? This is less hardcoding than the current MFILES (e.g. sys/kern being in the path picks up most of them). I still think that simply hiding MFILES in this file and updating it when new foo_if.m's are added isn't that onerous. Having a static .PATH.m would have that simplicity while still being somewhat automagical. |