[PowerPC] Fix emulators/qemu40 cacheline detection on powerpc
ClosedPublic
Actions

Authored by bdragon on Jan 18 2020, 3:25 AM.

Details

Reviewers

pkubaj
linimon
bofh

Commits

rP537979: MFH: r537912
rP537912: emulators/qemu40: Apply upstream fix for cacheline detection on big endian

Summary

This is qemu patch https://github.com/qemu/qemu/commit/5ca156cfde0f3821f15988619e51cf3cda99aaa6.patch

machdep.cacheline_size is an integer, not a long. Since PowerPC is
big-endian this causes sysctlbyname() to fill in the upper bits of the
argument, rather than the correct 'lower bits' of the word. Specify the
correct type to fix this.

Fixes
Assertion failed: ((isize & (isize - 1)) == 0), function init_cache_info, file util/cacheinfo.c, line 179.
Abort trap

when running qemu on FreeBSD powerpc.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Jan 18 2020, 3:25 AM

Herald added subscribers: alfredo, luporl, mat. · View Herald TranscriptJan 18 2020, 3:25 AM

linimon retitled this revision from [PowerPC] Fix qemu cacheline detection on powerpc to [PowerPC] Fix emulators/qemu40 cacheline detection on powerpc.Jan 19 2020, 9:09 AM

linimon added a reviewer: bofh.

bofh accepted this revision.Apr 27 2020, 8:19 PM

This revision is now accepted and ready to land.Apr 27 2020, 8:19 PM

pkubaj accepted this revision.Jun 4 2020, 4:07 PM

Closed by commit rP537912: emulators/qemu40: Apply upstream fix for cacheline detection on big endian (authored by bdragon). · Explain WhyJun 4 2020, 5:28 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rP537912: emulators/qemu40: Apply upstream fix for cacheline detection on big endian.

bdragon added a commit: rP537979: MFH: r537912.Jun 4 2020, 11:32 PM