fix riscv load/stores
ClosedPublic
Actions

Authored by br on Jan 17 2020, 4:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 4:27 AM

	Unknown Object (File)
	Wed, Oct 29, 11:12 PM

	Unknown Object (File)
	Sat, Oct 25, 5:20 PM

	Unknown Object (File)
	Wed, Oct 22, 8:55 PM

	Unknown Object (File)
	Wed, Oct 22, 8:55 PM

	Unknown Object (File)
	Wed, Oct 22, 8:55 PM

	Unknown Object (File)
	Wed, Oct 22, 11:18 AM

	Unknown Object (File)
	Thu, Oct 16, 5:08 AM

View All Files

Subscribers

imp

Details

Reviewers

jrtc27

Commits

rS356834: Use unsigned loads in fubyte, fuword16, generic_bs_r_1, generic_bs_r_2

Summary

Use unsigned load/stores as these functions should do zero-extend

Test Plan

these bugs discovered by running pci_read_cap()

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Jan 17 2020, 4:11 PM

Yes, this is exactly what I had in mind.

This revision is now accepted and ready to land.Jan 17 2020, 4:14 PM

Closed by commit rS356834: Use unsigned loads in fubyte, fuword16, generic_bs_r_1, generic_bs_r_2 (authored by br). · Explain WhyJan 17 2020, 4:48 PM

This revision was automatically updated to reflect the committed changes.

br added a commit: rS356834: Use unsigned loads in fubyte, fuword16, generic_bs_r_1, generic_bs_r_2.

Herald added a subscriber: imp. · View Herald TranscriptJan 17 2020, 4:48 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

bus_space_asm.S

6 lines

support.S

6 lines

Diff 66918

View Options

head/sys/riscv/riscv/bus_space_asm.S