Page MenuHomeFreeBSD

setextattr: Increase stdin buffer size to 4096
ClosedPublic

Authored by freqlabs on Jan 16 2020, 7:33 PM.
Tags
None
Referenced Files
F103211644: D23211.id66867.diff
Fri, Nov 22, 7:04 AM
Unknown Object (File)
Sun, Nov 17, 6:58 PM
Unknown Object (File)
Oct 22 2024, 4:41 PM
Unknown Object (File)
Sep 27 2024, 2:42 PM
Unknown Object (File)
Sep 25 2024, 10:07 AM
Unknown Object (File)
Sep 24 2024, 8:09 PM
Unknown Object (File)
Sep 24 2024, 2:54 PM
Unknown Object (File)
Sep 20 2024, 7:18 PM
Subscribers

Details

Summary

Extended attribute values can potentially be quite large. One test for ZFS is supposed to set a 200MB xattr. However, the buffer size for reading values from stdin with setextattr -i is so small that the test times out waiting for tiny chunks of data to be buffered and appended to an sbuf.

Increasing the buffer size should help alleviate some of the burden of reallocating larger sbufs when writing large extended attributes.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable