Fixup some ktr format issues noticed in a recent debugging session.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/vm/uma_core.c | ||
|---|---|---|
| 3526 ↗ | (On Diff #66658) | I think curthread is somewhat redundant since KTR always logs thread IDs. ... ah, I see it is in other KTR messages, so we should at least be consistent. |
| sys/vm/uma_core.c | ||
|---|---|---|
| 3526 ↗ | (On Diff #66658) | Yes. Although, it looks like there are only 4 others. We could fix those not to print thread instead? How thread is printed in uma_core.c is kind of weird anyway ("%x"). Separately it looks like ktr_tracepoint/ktr_verbose doesn't print the thread. I don't know if we care to change that. |
| sys/vm/uma_core.c | ||
|---|---|---|
| 3526 ↗ | (On Diff #66658) | I'd be fine with dropping the thread from the KTR messages. I think they used to be plain printf()s and were converted mechanically, which would explain why they're there. Hmm, I don't think I've ever used ktr_verbose before. I agree that it should print the thread pointer as well. |