Page MenuHomeFreeBSD

uma: fixup some ktr messages
ClosedPublic

Authored by rlibby on Sun, Jan 12, 8:04 PM.

Details

Summary

Fixup some ktr format issues noticed in a recent debugging session.

Test Plan

make buildkernel

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rlibby created this revision.Sun, Jan 12, 8:04 PM
markj accepted this revision.Sun, Jan 12, 8:20 PM
markj added inline comments.
sys/vm/uma_core.c
3526 ↗(On Diff #66658)

I think curthread is somewhat redundant since KTR always logs thread IDs.

... ah, I see it is in other KTR messages, so we should at least be consistent.

This revision is now accepted and ready to land.Sun, Jan 12, 8:20 PM
rlibby added inline comments.Sun, Jan 12, 8:49 PM
sys/vm/uma_core.c
3526 ↗(On Diff #66658)

Yes. Although, it looks like there are only 4 others. We could fix those not to print thread instead? How thread is printed in uma_core.c is kind of weird anyway ("%x").

Separately it looks like ktr_tracepoint/ktr_verbose doesn't print the thread. I don't know if we care to change that.

markj added inline comments.Sun, Jan 12, 8:56 PM
sys/vm/uma_core.c
3526 ↗(On Diff #66658)

I'd be fine with dropping the thread from the KTR messages. I think they used to be plain printf()s and were converted mechanically, which would explain why they're there.

Hmm, I don't think I've ever used ktr_verbose before. I agree that it should print the thread pointer as well.

rlibby updated this revision to Diff 66664.Mon, Jan 13, 12:34 AM

markj feedback, don't print threads

This revision now requires review to proceed.Mon, Jan 13, 12:34 AM
rlibby updated this revision to Diff 66665.Mon, Jan 13, 1:36 AM

missed one, and messed one up

markj accepted this revision.Mon, Jan 13, 5:11 AM
This revision is now accepted and ready to land.Mon, Jan 13, 5:11 AM
This revision was automatically updated to reflect the committed changes.