regulator_fixed: Add a get_voltage method
ClosedPublic
Actions

Authored by manu on Jan 2 2020, 3:27 PM.

Details

Reviewers

Commits

rS356803: regulator_fixed: Add a get_voltage method

Summary

Some consumer cannot know the voltage of the regulator without it.
While here, refuse to attach is min_voltage != max_voltage, it
shouldn't happens anyway.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Jan 2 2020, 3:27 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2020, 3:27 PM

This is slightly controversial. "regulator-min-microvolt" nor"regulator-max-microvolt" are not required properties for fixed regulators so we can't do this so simply. inmo,, we should monitor the presence of these properties and use this info for generate of the result.

This revision is now accepted and ready to land.Jan 6 2020, 3:32 PM

If there is no propoerties both value will be 0 and this will be ok.
If there is one there should be the other, even if it's not clear in the bindings doc I don't think that it make sense to only have one.

Closed by commit rS356803: regulator_fixed: Add a get_voltage method (authored by manu). · Explain WhyJan 16 2020, 8:52 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS356803: regulator_fixed: Add a get_voltage method.