Page MenuHomeFreeBSD

ncurses: correct check for gcc >= 5.0
ClosedPublic

Authored by kevans on Dec 29 2019, 1:53 AM.
Tags
None
Referenced Files
F168252949: D22952.id.diff
Thu, Aug 27, 4:57 AM
Unknown Object (File)
Sun, Aug 16, 6:52 AM
Unknown Object (File)
Mon, Aug 10, 10:42 AM
Unknown Object (File)
Mon, Aug 10, 10:28 AM
Unknown Object (File)
Sat, Aug 8, 8:39 PM
Unknown Object (File)
Sat, Aug 8, 8:27 AM
Unknown Object (File)
Fri, Aug 7, 5:45 PM
Unknown Object (File)
Thu, Aug 6, 9:06 AM
Subscribers

Details

Summary

The hack in question is intended to workaround seemingly bogus #line markers in cpp output. As far as I can tell, llvm cpp doesn't do this by default, so there's no reason to add -P.

In our /bin/sh, the main incantation should be placed in a sub-shell in order to properly pipe the output to fgrep.

The main motivation for this change is admittedly to stop emitting the noise about clang not being gcc in make -s buildworld

Test Plan

`

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 4:16 AM
This revision was automatically updated to reflect the committed changes.