Page MenuHomeFreeBSD

Check for USE_XORG being non-empty instead of just defined
Needs ReviewPublic

Authored by AMDmi3 on Dec 27 2019, 11:21 PM.

Details

Reviewers
bapt
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

The problem is that USE_XORG may be defined by other Uses modules, such as gl, but still empty.

For example

USES=gl
USE_GL=glut

leads to USE_XORG set via (in Uses/gl.mk):

USE_XORG+=  ${_GL_${_component}_USE_XORG}

to empty value, as _GL_glut_USE_XORG is not defined

This reproduces on graphics/devil when X11 option is off.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28341
Build 26438: arc lint + arc unit

Event Timeline

AMDmi3 created this revision.Dec 27 2019, 11:21 PM
bapt added a comment.Dec 28 2019, 3:47 AM

I am off my computer to really check but at quick glance it should probably be if defined and !empty

In D22939#502604, @bapt wrote:

I am off my computer to really check but at quick glance it should probably be if defined and !empty

Why, wouldn't it be redundant?