Page MenuHomeFreeBSD

Check for USE_XORG being non-empty instead of just defined
AbandonedPublic

Authored by AMDmi3 on Dec 27 2019, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 6:58 PM
Unknown Object (File)
Jan 17 2024, 5:14 AM
Unknown Object (File)
Jan 5 2024, 4:57 PM
Unknown Object (File)
Dec 22 2023, 9:30 PM
Unknown Object (File)
Jul 4 2023, 7:23 AM
Unknown Object (File)
Jun 20 2023, 11:41 PM
Unknown Object (File)
Jun 19 2023, 8:45 PM
Unknown Object (File)
May 11 2023, 2:14 PM
Subscribers

Details

Reviewers
bapt
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

The problem is that USE_XORG may be defined by other Uses modules, such as gl, but still empty.

For example

USES=gl
USE_GL=glut

leads to USE_XORG set via (in Uses/gl.mk):

USE_XORG+=  ${_GL_${_component}_USE_XORG}

to empty value, as _GL_glut_USE_XORG is not defined

This reproduces on graphics/devil when X11 option is off.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28341
Build 26438: arc lint + arc unit

Event Timeline

I am off my computer to really check but at quick glance it should probably be if defined and !empty

In D22939#502604, @bapt wrote:

I am off my computer to really check but at quick glance it should probably be if defined and !empty

Why, wouldn't it be redundant?

back on it almost 3 years later... sorry about that, after rereading, I think your proposal is ok, it would require at least an exp-run, but looks good to me.
Note I haven't tested it!!!

This revision is now accepted and ready to land.Jul 18 2022, 12:17 PM