[new port] systuils/gobi_loader: Firmware Loader for Qualcomm Gobi USB Chipsets

[zarychtam_plan-b.pwste.edu.pl]

Summary

Many people are still using this old piece of software but it's still missing in the ports tree. For source is used a trimmed fork of known to be working for years https://github.com/kicer/gobi_loader project. Original http://www.codon.org.uk/~mjg59/gobi_loader probably never worked on FreeBSD.

Test Plan

Initial version. Needs more testing and quality assurance.

[zarychtam_plan-b.pwste.edu.pl]

Update to pkg-message and cleanup.

[diizzy]

gobi_loader/Makefile

16

You can remove this line
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html --> 5.4.3

[diizzy]

gobi_loader/Makefile

23

Remove blank line

25

share/examples/devd/gobi_loader.conf.sample might be a better idea as it's not going to work out of box due to missing firmware?

gobi_loader/files/gobi.conf.in

7

Is it possible to avoid hardcoding /dev/cuaU0?
/boot/firmware/gobi/ should probably be /usr/local/lib/firmware? (use ports path variables)

gobi_loader/pkg-message

6

Multiple typos and what should the firmware file name be?

[zarychtam_plan-b.pwste.edu.pl]

This comment was removed by zarychtam_plan-b.pwste.edu.pl.

[zarychtam_plan-b.pwste.edu.pl]

Updated to meet reviewer's suggestions

[zarychtam_plan-b.pwste.edu.pl]

gobi_loader/Makefile

16

This one could be useful

[diizzy]

gobi_loader/Makefile

16

Not sure why the line shifted but I meant GH_PROJECT=

[zarychtam_plan-b.pwste.edu.pl]

Removed GH_PROJECT= and a few whitespaces; reachable e-mail address of port maintainer added.

[imp]

So what's the status of this port?

[zarychtam_plan-b.pwste.edu.pl]

I have updated patch to clarify how to obtain firmware files. Port builds and works 100% fine. It was tested with portilint and poudriere testport.

[imp]

sysutils/gobi_loader/Makefile

22 ↗

(On Diff #90816)

This could use another tab indent...

But I'll fix that when committing.