Page MenuHomeFreeBSD

Merge commit d3aeac8e2 from llvm git (by Justin Hibbits)
ClosedPublic

Authored by dim on Dec 23 2019, 7:16 PM.
Tags
None
Referenced Files
F132297481: D22913.id65931.diff
Wed, Oct 15, 3:43 PM
F132250234: D22913.id66001.diff
Wed, Oct 15, 4:49 AM
F132250228: D22913.id.diff
Wed, Oct 15, 4:49 AM
Unknown Object (File)
Tue, Oct 14, 7:17 PM
Unknown Object (File)
Wed, Oct 8, 11:00 PM
Unknown Object (File)
Tue, Oct 7, 2:26 AM
Unknown Object (File)
Mon, Oct 6, 12:40 AM
Unknown Object (File)
Wed, Sep 24, 5:57 AM
Subscribers

Details

Summary
[PowerPC] Only use PLT annotations if using PIC relocation model

Summary:

The default static (non-PIC, non-PIE) model for 32-bit powerpc does
not use @PLT annotations and relocations in GCC.  LLVM shouldn't use
@PLT annotations either, because it breaks secure-PLT linking with
(some versions of?) GNU LD.

Update the available-externally.ll test to reflect that default mode
should be the same as the static relocation, by using the same check
prefix.

Reviewed by:    sfertile
Differential Revision: https://reviews.llvm.org/D70570

This diff needed some fuzz to apply, double-checking it via this review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

contrib/llvm-project/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
4960 ↗(On Diff #65931)

The original diff I had created, before rebasing on the giant refactor used TM.getRelocationModel(). I think this should still work, though.

This revision is now accepted and ready to land.Dec 23 2019, 10:30 PM