Page MenuHomeFreeBSD

Merge commit d3aeac8e2 from llvm git (by Justin Hibbits)
ClosedPublic

Authored by dim on Dec 23 2019, 7:16 PM.
Tags
None
Referenced Files
F103507836: D22913.diff
Mon, Nov 25, 9:29 PM
Unknown Object (File)
Sun, Nov 24, 7:33 PM
Unknown Object (File)
Mon, Nov 18, 11:49 PM
Unknown Object (File)
Sat, Nov 16, 3:54 AM
Unknown Object (File)
Sat, Nov 16, 12:32 AM
Unknown Object (File)
Fri, Nov 8, 3:18 AM
Unknown Object (File)
Wed, Nov 6, 5:22 PM
Unknown Object (File)
Oct 25 2024, 9:36 PM
Subscribers

Details

Summary
[PowerPC] Only use PLT annotations if using PIC relocation model

Summary:

The default static (non-PIC, non-PIE) model for 32-bit powerpc does
not use @PLT annotations and relocations in GCC.  LLVM shouldn't use
@PLT annotations either, because it breaks secure-PLT linking with
(some versions of?) GNU LD.

Update the available-externally.ll test to reflect that default mode
should be the same as the static relocation, by using the same check
prefix.

Reviewed by:    sfertile
Differential Revision: https://reviews.llvm.org/D70570

This diff needed some fuzz to apply, double-checking it via this review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

contrib/llvm-project/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
4960 ↗(On Diff #65931)

The original diff I had created, before rebasing on the giant refactor used TM.getRelocationModel(). I think this should still work, though.

This revision is now accepted and ready to land.Dec 23 2019, 10:30 PM