Page MenuHomeFreeBSD

gcc: quiet Wattribute for no_sanitize("address")
ClosedPublic

Authored by rlibby on Dec 19 2019, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 7, 5:45 AM
Unknown Object (File)
Tue, Nov 25, 6:36 PM
Unknown Object (File)
Tue, Nov 25, 10:09 AM
Unknown Object (File)
Fri, Nov 21, 1:51 PM
Unknown Object (File)
Fri, Nov 21, 3:14 AM
Unknown Object (File)
Thu, Nov 20, 9:47 AM
Unknown Object (File)
Wed, Nov 19, 3:04 PM
Unknown Object (File)
Mon, Nov 17, 4:27 PM
Subscribers

Details

Summary

This is an unfortunate instances where the __has_attribute check does
not function usefully. Gcc does have the attribute, but for gcc it only
applies to functions, not variables, and trying to apply it to a
variable generates Wattribute. So far we only apply the attribute to
variables. Only enable the attribute for clang, for now.

Test Plan

make buildkernel
make CROSS_TOOLCHAIN=amd64-gcc9 buildkernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Works for now. If I have time over the break I’ll take a look at whether gcc could easily be extended to apply this attribute to variables where it makes sense.

This revision is now accepted and ready to land.Dec 19 2019, 4:29 PM
This revision was automatically updated to reflect the committed changes.