Page MenuHomeFreeBSD
Differential D22874

make tmpfs.h friendly with _KERNEL undefined
ClosedPublic
Actions

Authored by dougm on Dec 19 2019, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 6:57 AM
Unknown Object (File)
Mon, Mar 23, 4:34 AM
Unknown Object (File)
Mon, Mar 23, 4:34 AM
Unknown Object (File)
Mon, Mar 23, 12:42 AM
Unknown Object (File)
Mon, Mar 23, 12:42 AM
Unknown Object (File)
Sun, Mar 22, 2:42 AM
Unknown Object (File)
Tue, Mar 17, 5:08 AM
Unknown Object (File)
Tue, Mar 17, 3:46 AM
View All Files
Subscribers
imp
ler

Details

Reviewers
alc
kib
Commits
rS355913: Including <sys/tmpfs.h> into non-kernel software leads to a
Summary

Including <sys/tmpfs.h> into non-kernel software leads to a compilation error because, without _KERNEL defined, the macro TMPFS_VALIDATE_DIR is invoked, but never defined. User-level software that includes sys/tmpfs.h must define _KERNEL to make the definition of TMPFS_VALIDATE_DIR visible.

This change puts all the inline functions that, directly or indirectly, invoke MPASS into the scope of the _KERNEL block, allowing many user-space includers of <sys/tmpfs.h> to stop defining _KERNEL.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Dec 19 2019, 4:16 AM
kib added inline comments.Dec 19 2019, 2:26 PM
sys/fs/tmpfs/tmpfs.h
407 ↗(On Diff #65804)

The practice of including headers from headers is discouraged. It should be handled by consumer.

538 ↗(On Diff #65804)

This is fine.

dougm updated this revision to Diff 65813.Dec 19 2019, 4:20 PM
dougm edited the summary of this revision. (Show Details)

Remove #include <sys/lock.h> from tmpfs.h.

Leave #include <sys/queue.h> and #include <sys/tree.h> in tmpfs.h.

dougm marked 2 inline comments as done.Dec 19 2019, 4:21 PM
kib accepted this revision.Dec 19 2019, 4:31 PM
This revision is now accepted and ready to land.Dec 19 2019, 4:31 PM
alc accepted this revision.Dec 19 2019, 4:36 PM
Closed by commit rS355913: Including <sys/tmpfs.h> into non-kernel software leads to a (authored by dougm). · Explain WhyDec 19 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS355913: Including <sys/tmpfs.h> into non-kernel software leads to a.
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2019, 4:40 PM

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
tmpfs/
3 lines

Diff 65814

View Options

head/sys/fs/tmpfs/tmpfs.h

Loading...