Avoid a tautological bitwise compare.
ClosedPublic
Actions

Authored by brooks on Dec 16 2019, 11:09 PM.

Details

Reviewers

imp
mav
dim

Commits

rS355965: MFC r355830:
rS355964: MFC r355830:
rS355830: Avoid a tautological bitwise compare.

Summary

This looks like a bit of debugging code that sliped into the initial
import of the new ATA framework. This changes the behavior to omit a
line of output that appears to have been intended for omission.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Dec 16 2019, 11:09 PM

Harbormaster completed remote builds in B28191: Diff 65730.Dec 16 2019, 11:09 PM

It is OK, but generally I don't care much. I was never able to get any documentation for the Promise controllers, so I was never able to make them work in full, including NCQ and PMP. And now the code is close to be dead, since IIRC all of those chips were PCI-X.

This revision is now accepted and ready to land.Dec 16 2019, 11:24 PM

Closed by commit rS355830: Avoid a tautological bitwise compare. (authored by brooks). · Explain WhyDec 17 2019, 12:10 AM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS355830: Avoid a tautological bitwise compare..

brooks added a commit: rS355964: MFC r355830:.Dec 20 2019, 10:07 PM

brooks added a commit: rS355965: MFC r355830:.Dec 20 2019, 10:12 PM