Page MenuHomeFreeBSD

devel/llvm90 fix PowerPC64 ABI detection

Authored by alfredo on Dec 14 2019, 12:34 AM.



This fixes PowerPC64 automatic ABI detection not working properly. ELFv2 option should be marked if you are on ELFv2 environment.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Dec 14 2019, 1:18 AM
linimon added inline comments.
224 ↗(On Diff #65642)

I don't understand. I thought once you included you couldn't change OPTIONS any further?

224 ↗(On Diff #65642)

I don't know, this "just works". What doesn't work is checking PPC_ABI in the beginning of the file, when OPTIONS are being defined. says:

...OPTIONS definitions must appear before the inclusion of PORT_OPTIONS values can only be tested after the inclusion of Inclusion of can be used instead, too, and is still widely used in ports written before the introduction of But be aware that some variables will not work as expected after the inclusion of, typically some USE_* flags....

This revision was automatically updated to reflect the committed changes.