devel/llvm90 fix PowerPC64 ABI detection
ClosedPublic
Actions

Authored by alfredo on Dec 14 2019, 12:34 AM.

Details

Reviewers

pkubaj
brooks

Commits

rP521968: devel/llvm90: fix ELFv2 option autodetection

Summary

This fixes PowerPC64 automatic ABI detection not working properly. ELFv2 option should be marked if you are on ELFv2 environment.

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

LGTM.

This revision is now accepted and ready to land.Dec 14 2019, 1:18 AM

linimon added inline comments.

devel/llvm90/Makefile
224 ↗	(On Diff #65642)	I don't understand. I thought once you included bsd.port.options.mk you couldn't change OPTIONS any further?

devel/llvm90/Makefile
224 ↗	(On Diff #65642)	I don't know, this "just works". What doesn't work is checking PPC_ABI in the beginning of the file, when OPTIONS are being defined. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html says: ...OPTIONS definitions must appear before the inclusion of bsd.port.options.mk. PORT_OPTIONS values can only be tested after the inclusion of bsd.port.options.mk. Inclusion of bsd.port.pre.mk can be used instead, too, and is still widely used in ports written before the introduction of bsd.port.options.mk. But be aware that some variables will not work as expected after the inclusion of bsd.port.pre.mk, typically some USE_* flags....