Page MenuHomeFreeBSD

cxgbe(4): Use the _XT variant of the CPL used to transmit NIC traffic.
ClosedPublic

Authored by np on Dec 12 2019, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2024, 11:17 AM
Unknown Object (File)
Dec 20 2023, 1:57 AM
Unknown Object (File)
Nov 14 2023, 10:09 PM
Unknown Object (File)
Nov 9 2023, 3:34 AM
Unknown Object (File)
Nov 7 2023, 1:40 PM
Unknown Object (File)
Nov 5 2023, 5:41 PM
Unknown Object (File)
Nov 1 2023, 10:07 PM
Unknown Object (File)
Oct 30 2023, 10:03 PM
Subscribers

Details

Summary

CPL_TX_PKT_XT disables the internal parser on the chip and instead
relies on the driver to provide the exact length of the L2 and L3
headers. This allows hw checksumming and TSO to be used with L2 and
L3 encapsulations that the chip doesn't understand directly.

Note that netmap tx still uses the old CPL as it never uses the hw
to generate the checksum on tx.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks ok to me. I can test ktls after commit.

sys/dev/cxgbe/crypto/t4_kern_tls.c
1430 ↗(On Diff #65570)

Blank line before the comment? This was intended to match the style in t4_sge.c though when I copied from it, and now the code is in a different place so you could just drop the comment instead.

This revision is now accepted and ready to land.Dec 12 2019, 11:54 PM

Incorporate feedback from jhb@.

This revision now requires review to proceed.Dec 13 2019, 12:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2019, 8:39 PM
This revision was automatically updated to reflect the committed changes.