Page MenuHomeFreeBSD

Add WITH_/WITHOUT_CLEAN option to replace NO_CLEAN
ClosedPublic

Authored by emaste on Dec 11 2019, 2:40 PM.
Tags
None
Referenced Files
F107157995: D22762.diff
Sat, Jan 11, 12:31 AM
Unknown Object (File)
Fri, Dec 27, 3:58 AM
Unknown Object (File)
Dec 10 2024, 7:25 PM
Unknown Object (File)
Dec 7 2024, 11:54 AM
Unknown Object (File)
Nov 21 2024, 11:41 PM
Unknown Object (File)
Oct 15 2024, 8:31 PM
Unknown Object (File)
Oct 6 2024, 12:46 AM
Unknown Object (File)
Oct 3 2024, 2:21 PM
Subscribers
None

Details

Summary

This allows use of the standard src.conf configuration for controlling whether the tree is cleaned before build or not. The default is still to clean.

Posted for initial review/comment; to commit will include an UPDATING entry. We also need to investigate these files that contain NO_CLEAN:

share/man/man5/make.conf.5
share/man/man7/build.7
share/man/man8/nanobsd.8
share/mk/local.dirdeps.mk
tools/build/beinstall.sh
tools/tinder.sh
tools/tools/nanobsd/defaults.sh
tools/tools/nanobsd/nanobsd.sh
tools/tools/nanobsd/pcengines/common.conf

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste added inline comments.
Makefile.inc1
459โ€“461

Probably can commit this part (.warning->.error) first

Makefile.inc1
1684

We likely should consider the kernel version too

Not worth trying to change anything.

In discussion with @imp still desire to keep the MK transition.

@bdrewery would appreciate your feedback on both the transition to MK_CLEAN as well as the goal of changing the default in the future.

bdrewery added inline comments.
Makefile.inc1
459โ€“465

I think this logic could be generalized in src/bsd.opts.mk. But that would probably expand the behavior to other flags. It still might make sense to move this logic there though?

1684

Is there a 'make kernel-clean' because I wanted it just a few days ago and couldn't find one. I didn't look very hard though.

This revision is now accepted and ready to land.Mar 20 2020, 9:54 PM
This revision was automatically updated to reflect the committed changes.