Add WITH_/WITHOUT_CLEAN option to replace NO_CLEAN
ClosedPublic
Actions

Authored by emaste on Dec 11 2019, 2:40 PM.

Details

Reviewers

imp
bdrewery

Commits

rS365439: Add WITH_/WITHOUT_CLEAN option to replace NO_CLEAN

Summary

This allows use of the standard src.conf configuration for controlling whether the tree is cleaned before build or not. The default is still to clean.

Posted for initial review/comment; to commit will include an UPDATING entry. We also need to investigate these files that contain NO_CLEAN:

share/man/man5/make.conf.5
share/man/man7/build.7
share/man/man8/nanobsd.8
share/mk/local.dirdeps.mk
tools/build/beinstall.sh
tools/tinder.sh
tools/tools/nanobsd/defaults.sh
tools/tools/nanobsd/nanobsd.sh
tools/tools/nanobsd/pcengines/common.conf

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Dec 11 2019, 2:40 PM

emaste added inline comments.

Makefile.inc1
459–461 ↗	(On Diff #65492)	Probably can commit this part (.warning->.error) first

imp added inline comments.Dec 11 2019, 3:36 PM

Makefile.inc1
1684 ↗	(On Diff #65492)	We likely should consider the kernel version too

emaste abandoned this revision.Dec 13 2019, 2:54 PM

Not worth trying to change anything.

In discussion with @imp still desire to keep the MK transition.

@bdrewery would appreciate your feedback on both the transition to MK_CLEAN as well as the goal of changing the default in the future.

rebase

bdrewery accepted this revision.Mar 20 2020, 9:54 PM

bdrewery added inline comments.

Makefile.inc1
429–432 ↗	(On Diff #69722)	I think this logic could be generalized in src/bsd.opts.mk. But that would probably expand the behavior to other flags. It still might make sense to move this logic there though?
1684 ↗	(On Diff #65492)	Is there a 'make kernel-clean' because I wanted it just a few days ago and couldn't find one. I didn't look very hard though.