Page MenuHomeFreeBSD

Correct the offset of static TLS variables for Initial-Exec.
ClosedPublic

Authored by jhb on Dec 3 2019, 10:37 PM.

Details

Summary

%tp points to the start of the TLS block after the tcb, but
Obj_Entry.tlsoffset includes the tcb, so subtract the size of the
tcb to compute the offset relative to %tp.

Test Plan

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Dec 3 2019, 10:37 PM
jhb added a reviewer: jrtc27.Dec 3 2019, 10:37 PM
jrtc27 added a comment.EditedDec 3 2019, 11:58 PM

Note that this is the same fix as rS339072 for powerpc and rS342671 for powerpc64, and matches the mips implementation, all of which use Variant I TLS and thus should look the same (ignoring the values of the constants themselves).

(Also, %tp in the revision summary looks odd, RISC-V doesn't prefix registers with anything)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2019, 9:56 PM
This revision was automatically updated to reflect the committed changes.