Correct the offset of static TLS variables for Initial-Exec.
ClosedPublic
Actions

Authored by jhb on Dec 3 2019, 10:37 PM.

Details

Reviewers

Commits

rS355599: Correct the offset of static TLS variables for Initial-Exec on RISC-V.

Summary

%tp points to the start of the TLS block after the tcb, but
Obj_Entry.tlsoffset includes the tcb, so subtract the size of the
tcb to compute the offset relative to %tp.

Test Plan

ran t_tls_dynamic tests which failed before after the compiler change to not force LE in https://github.com/llvm/llvm-project/commit/da7b129b1b52bdc52b02b546b75f90fad07f6d3a

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 3 2019, 10:37 PM

Herald added a subscriber: bdragon. · View Herald TranscriptDec 3 2019, 10:37 PM

Harbormaster completed remote builds in B27928: Diff 65187.Dec 3 2019, 10:37 PM

jhb added a reviewer: jrtc27.Dec 3 2019, 10:37 PM

Note that this is the same fix as rS339072 for powerpc and rS342671 for powerpc64, and matches the mips implementation, all of which use Variant I TLS and thus should look the same (ignoring the values of the constants themselves).

(Also, %tp in the revision summary looks odd, RISC-V doesn't prefix registers with anything)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2019, 9:56 PM

Closed by commit rS355599: Correct the offset of static TLS variables for Initial-Exec on RISC-V. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS355599: Correct the offset of static TLS variables for Initial-Exec on RISC-V..

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2019, 9:56 PM