Page MenuHomeFreeBSD
Differential D2258

Add support for a netisr polling tunable, which allows run time switching of device polling rather than having it only be controlled by the compile time option.
ClosedPublic
Actions

Authored by gnn on Apr 8 2015, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 12 2023, 9:35 AM
Unknown Object (File)
Nov 10 2023, 8:48 PM
Unknown Object (File)
Nov 10 2023, 7:15 PM
Unknown Object (File)
Nov 8 2023, 7:11 PM
Unknown Object (File)
Nov 6 2023, 9:39 PM
Unknown Object (File)
Nov 6 2023, 5:31 AM
Unknown Object (File)
Oct 9 2023, 7:43 PM
Unknown Object (File)
Oct 9 2023, 8:35 AM
View All 66 Files
Subscribers
hiren

Details

Reviewers
hiren
Group Reviewers
network
Commits
rS281276: Add support for a netisr polling tunable, which allows run time switching of
Summary

Rubicon Communications (Netgate)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gnn updated this revision to Diff 4742.Apr 8 2015, 3:09 PM
gnn retitled this revision from to Add support for a netisr polling tunable, which allows run time switching of device polling rather than having it only be controlled by the compile time option. Rubicon Communications (Netgate).
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptApr 8 2015, 3:09 PM
gnn added a subscriber: network.Apr 8 2015, 3:10 PM
gnn added a reviewer: network.Apr 8 2015, 3:14 PM
gnn removed subscribers: network, imp.
hiren added a subscriber: hiren.Apr 8 2015, 4:48 PM
hiren added inline comments.
sys/net/netisr.c
1137 ↗(On Diff #4742)

This seems unrelated to the proposed change. Is this intended? With this we are changing default value from '1' to 'mp_ncpus', if I understand this correctly.

gnn added inline comments.Apr 8 2015, 7:09 PM
sys/net/netisr.c
1137 ↗(On Diff #4742)

I went back and forth on this one. I could revert it to 1, but I really think if we've gone to device polling we want to move to using all the CPUs. I can be convinced otherwise.

gnn updated this revision to Diff 4747.Apr 8 2015, 8:02 PM
gnn retitled this revision from Add support for a netisr polling tunable, which allows run time switching of device polling rather than having it only be controlled by the compile time option. Rubicon Communications (Netgate) to Add support for a netisr polling tunable, which allows run time switching of device polling rather than having it only be controlled by the compile time option..
gnn updated this object.

Address comment from hiren wrt the default if no cpu limit it set.

Updating D2258: Add support for a netisr polling tunable, which allows run time switching of

device polling rather than having it only be controlled by the compile
time option.

hiren accepted this revision.Apr 8 2015, 8:08 PM
hiren added a reviewer: hiren.
This revision is now accepted and ready to land.Apr 8 2015, 8:08 PM
gnn closed this revision.Apr 8 2015, 8:25 PM
gnn updated this revision to Diff 4748.

Closed by commit rS281276 (authored by @gnn).

Revision Contents
Changeset List

PathSize
head/
sys/
net/
23 lines

Diff 4748

View Options

head/sys/net/netisr.c

Loading...