Page MenuHomeFreeBSD

games/kdegames, devel/py-qt5: Canonicalize option names
ClosedPublic

Authored by tobik on Sun, Nov 24, 4:28 PM.

Details

Summary

games/kdegames and devel/py-qt5 are one of the last few ports that
trigger the following QA warnings:

/!\ kdegames-19.08.3: Makefile warnings, please consider fixing /!\

These options name have characters outside of [-_A-Z0-9]:

bomber bovo granatier kapman katomic kblackbox kblocks kbounce kbreakout
kdiamond kfourinline killbots kiriki kjumpingcube klickety klines kmahjongg
kmines knavalbattle knetwalk knights kolf kollision kpat kshisen ksirk ksquares
ktuberling picmi

/!\ py36-qt5-5.13.1: Makefile warnings, please consider fixing /!\

These options name have characters outside of [-_A-Z0-9]:

core dbus dbussupport demo designer designerplugin gui multimedia
multimediawidgets network opengl printsupport qml qscintilla2 quickwidgets
serialport sql svg test webchannel webengine webkit webkitwidgets widgets xml
xmlpatterns

Can we clean it up?

I regenerated the options list in py-qt5 and it was missing a
dependency on py-qt5-help. Also py-sip but I am not sure if that
is right.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Sun, Nov 24, 4:28 PM
tcberner accepted this revision.Sun, Nov 24, 7:15 PM
tcberner added a subscriber: tcberner.

Lgtm, under the assumption, it works as before.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 25, 7:55 AM
This revision was automatically updated to reflect the committed changes.
tobik added a comment.Mon, Nov 25, 3:59 PM

Lgtm, under the assumption, it works as before.

Thanks. I fluffed it though and made all KDE games lose their COMMENT :-/. Should be fixed after rP518409.