Page MenuHomeFreeBSD

Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD
ClosedPublic

Authored by rrs on Nov 21 2019, 3:23 PM.

Details

Summary

This revision moves a few deck chairs around.

  1. We go to a global limit V_tcp_split/alloc_limits so that both rack and bbr use the same sendmap limits
  2. NETFLIX_STATS becomes STATS in most places except specific instances
  3. Until the last STATS update lands if you don't have NETFLIX_STATS defined (and you should not) STATS is undefined in bbr and rack
  4. The SaD experimental detection parameters is placed in the stack so that both bbr and rack can use it
Test Plan

Basically this one is fairly easy, just bring up the stacks and make sure they now
use the common sysctl's (and load of course).

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rrs retitled this revision from Fix up several sysctl to Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.Nov 21 2019, 3:27 PM
rrs edited the summary of this revision. (Show Details)
rrs edited the test plan for this revision. (Show Details)
rrs added reviewers: transport, tuexen, jtl.
This revision is now accepted and ready to land.Dec 4 2019, 12:15 PM