Fix error found by new clang operator precendence warning
ClosedPublic
Actions

Authored by arichardson on Nov 17 2019, 5:27 PM.

Tags

None

Referenced Files

	F163078925: D22433.id64501.diff
	Sun, Jul 19, 9:44 PM

	Unknown Object (File)
	Sat, Jul 11, 10:46 PM

	Unknown Object (File)
	Tue, Jul 7, 11:25 PM

	Unknown Object (File)
	Sun, Jul 5, 3:40 AM

	Unknown Object (File)
	Sat, Jul 4, 2:29 PM

	Unknown Object (File)
	May 26 2026, 4:26 AM

	Unknown Object (File)
	May 26 2026, 4:21 AM

	Unknown Object (File)
	May 25 2026, 9:03 PM

View All Files

Subscribers

imp

Details

Reviewers

• ian

Commits

rS360317: MFC r354796 (by arichardson):
rS354796: Fix error found by new clang operator precendence warning

Summary

error: operator '?:' has lower precedence than '|'; '|' will be evaluated first

I discovered this in CheriBSD after updating our fork of clang to the latest
upstream master.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Nov 17 2019, 5:27 PM

Harbormaster completed remote builds in B27608: Diff 64501.Nov 17 2019, 5:27 PM

• ian accepted this revision.Nov 17 2019, 6:00 PM

This revision is now accepted and ready to land.Nov 17 2019, 6:00 PM

Closed by commit rS354796: Fix error found by new clang operator precendence warning (authored by arichardson). · Explain WhyNov 17 2019, 7:04 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS354796: Fix error found by new clang operator precendence warning.

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2019, 7:04 PM

dim added a commit: rS360317: MFC r354796 (by arichardson):.Apr 25 2020, 3:46 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

i2c/

i2c.c

2 lines

Diff 64509

View Options

Fix error found by new clang operator precendence warningClosedPublicActions