Paths

Table of Contentst

Differential D22390

netmap: Check if we already ran mmap before we attempt it
ClosedPublic
Actions

Authored by nc on Nov 15 2019, 7:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 19, 7:56 PM

	Unknown Object (File)
	Tue, Aug 18, 5:51 PM

	Unknown Object (File)
	Sat, Aug 15, 9:30 AM

	Unknown Object (File)
	Thu, Aug 13, 10:52 PM

	Unknown Object (File)
	Tue, Aug 11, 4:25 PM

	Unknown Object (File)
	Tue, Aug 11, 4:34 AM

	Unknown Object (File)
	Mon, Aug 10, 2:28 PM

	Unknown Object (File)
	Mon, Aug 10, 2:27 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

vmaffione
g.lettieri_iet.unipi.it

Commits

rS355133: MFC r354867:
rS354867: netmap: check if we already ran mmap before we attempt it

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nc created this revision.Nov 15 2019, 7:27 PM

Herald added subscribers: Contributor Reviews (src), ae, imp. · View Herald TranscriptNov 15 2019, 7:27 PM

lwhsu added a reviewer: vmaffione.Nov 16 2019, 2:39 PM

vmaffione added inline comments.Nov 17 2019, 2:58 PM

head/sys/net/netmap_user.h
985	I would just return here. If done_mmap == 1, it means that somebody already went through the initializations a the end of this function.
1003	This can go away (see above).

vmaffione added a reviewer: g.lettieri_iet.unipi.it.Nov 17 2019, 2:59 PM

Completely makes sense. New diff incorporates your recommended changes.

Just one question: did this change come from some usage scenario? In theory you should not call nm_mmap() more than once.

This revision is now accepted and ready to land.Nov 18 2019, 8:32 PM

I was just grepping through the source tree for TODO occurrences and make patches from them.

Also, how long would it take for the patch to land in HEAD?

I'll do it tonight.

Closed by commit rS354867: netmap: check if we already ran mmap before we attempt it (authored by vmaffione). · Explain WhyNov 19 2019, 9:30 PM

This revision was automatically updated to reflect the committed changes.

vmaffione added a commit: rS354867: netmap: check if we already ran mmap before we attempt it.

vmaffione added a commit: rS355133: MFC r354867:.Nov 27 2019, 6:52 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

3 lines

Diff 64585

head/sys/net/netmap_user.h

Loading...