Page MenuHomeFreeBSD

netmap: Check if we already ran mmap before we attempt it
ClosedPublic

Authored by nc on Nov 15 2019, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 3:15 AM
Unknown Object (File)
Dec 3 2024, 5:04 PM
Unknown Object (File)
Nov 28 2024, 11:54 AM
Unknown Object (File)
Nov 23 2024, 8:46 PM
Unknown Object (File)
Nov 23 2024, 8:26 PM
Unknown Object (File)
Nov 23 2024, 1:45 PM
Unknown Object (File)
Nov 22 2024, 2:10 AM
Unknown Object (File)
Nov 20 2024, 1:17 AM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

head/sys/net/netmap_user.h
985

I would just return here. If done_mmap == 1, it means that somebody already went through the initializations a the end of this function.

1003

This can go away (see above).

Completely makes sense. New diff incorporates your recommended changes.

Just one question: did this change come from some usage scenario? In theory you should not call nm_mmap() more than once.

This revision is now accepted and ready to land.Nov 18 2019, 8:32 PM

I was just grepping through the source tree for TODO occurrences and make patches from them.

Also, how long would it take for the patch to land in HEAD?