Page MenuHomeFreeBSD

Use __ as the separator for the exported vars in bsd.compiler/linker.mk
ClosedPublic

Authored by arichardson on Nov 15 2019, 3:41 PM.

Details

Summary

By using '__' instead of '.' as the separator we can also support systems
that use dash as /bin/sh (it's the default shell on Ubuntu/Debian). Dash
will unset any environment variables that use a non alphanumeric+undedscore
character and therefore submakes will fail to import the COMPILER_*
variables if we use '.' as the separator.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Nov 15 2019, 3:41 PM
emaste accepted this revision.Nov 15 2019, 3:59 PM

Seems reasonable to me.

For reference this was introduced in rS320246 / review D11310.

This revision is now accepted and ready to land.Nov 15 2019, 3:59 PM