Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro.
ClosedPublic
Actions

Authored by brooks on Nov 13 2019, 12:07 AM.

Tags

None

Referenced Files

	F170175383: D22338.diff
	Thu, Sep 3, 6:01 PM

	F170104282: D22338.id.diff
	Thu, Sep 3, 12:49 PM

	F169962654: D22338.id64280.diff
	Thu, Sep 3, 3:01 AM

	Unknown Object (File)
	Wed, Sep 2, 1:37 PM

	Unknown Object (File)
	Wed, Sep 2, 8:47 AM

	Unknown Object (File)
	Wed, Sep 2, 1:08 AM

	Unknown Object (File)
	Tue, Sep 1, 11:15 PM

	Unknown Object (File)
	Tue, Sep 1, 6:04 PM

View All Files

Subscribers

imp

Details

Reviewers

jhb
kevans

Commits

rS354921: MFC r354688:
rS354688: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro.

Summary

The second argument should have been "pa" not "ps". It worked by accident
because the argument was always "pa" which was an in-scope local
variable.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Nov 13 2019, 12:07 AM

Harbormaster completed remote builds in B27482: Diff 64257.Nov 13 2019, 12:07 AM

jhb accepted this revision.Nov 13 2019, 12:42 AM

This revision is now accepted and ready to land.Nov 13 2019, 12:42 AM

kevans accepted this revision.Nov 13 2019, 3:47 AM

Closed by commit rS354688: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro. (authored by brooks). · Explain WhyNov 13 2019, 6:10 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS354688: Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro..

Herald added a subscriber: imp. · View Herald TranscriptNov 13 2019, 6:11 PM

brooks added a commit: rS354921: MFC r354688:.Nov 20 2019, 11:09 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

pmap.c

2 lines

Diff 64280

View Options

Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro.ClosedPublicActions