mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters

[arrowd]

Summary

Fix for bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231656

[arrowd]

Bump.

[arrowd]

Bump.

[arrowd]

Bump.

[arrowd]

[donner]

contrib/smbfs/lib/smb/rcfile.c

166–171 ↗

(On Diff #64102)

I'd propose:

for(sectletter = sectname; *sectletter; sectletter++) {
   if(isupper(*sectletter)  || *sectletter == ':')
      continue;
   if(!strcmp(sectname, "default"))
      dprintf(STDERR_FILENO, "warning: Section name [%s] may contain problematic chars, like lower-case letters\n", sectname);
   break;
}

This makes the scan more readable, short cut if the result is known, and keep the search and the response together.

[bapt]

contrib/smbfs/lib/smb/rcfile.c

166–171 ↗

(On Diff #64102)

I like the proposal better, but I think that special chars should be allowed, then testing isupper and !islower should do the trick instead of only testing ':'

[donner]

contrib/smbfs/lib/smb/rcfile.c

166–171 ↗

(On Diff #64102)

This would simplify the code to:

for(sectletter = sectname; *sectletter; sectletter++) {
  if(islower(*sectletter)) {
     if(!strcmp(sectname, "default"))
        dprintf(STDERR_FILENO, "warning: Section name [%s] contains lower-case letters\n", sectname);
     break;
  }
}

[arrowd]

Address comments.

[donner]

contrib/smbfs/lib/smb/rcfile.c

161–162 ↗

(On Diff #66292)

If the section was found, the check is skipped.

That's okay, because the check should be done only if the a new section is encountered the first time.