route: remove an outdated comment from rtrequest1_fib
Needs ReviewPublic
Actions

Authored by jacob.e.keller_intel.com on Nov 5 2019, 5:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 11:39 AM

	Unknown Object (File)
	Sat, Apr 6, 6:54 AM

	Unknown Object (File)
	Dec 20 2023, 3:03 AM

	Unknown Object (File)
	Dec 10 2023, 9:46 PM

	Unknown Object (File)
	Nov 24 2023, 1:06 AM

	Unknown Object (File)
	Nov 15 2023, 7:40 AM

	Unknown Object (File)
	Nov 9 2023, 10:02 PM

	Unknown Object (File)
	Nov 5 2023, 10:29 AM

View All 15 Files

Subscribers

Details

Reviewers

jhb
mmacy
erj

Summary

revision r334222 modified rtrequest1_fib to always take a reference on
the ifa structure. However, the comment above this indicates the code is
relying on a reference from rt_getifa_fib().

Since this is no longer the case, remove this outdated comment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27358
Build 25608: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.Nov 5 2019, 5:40 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 5 2019, 5:40 PM

Harbormaster completed remote builds in B27358: Diff 63965.Nov 5 2019, 5:40 PM

I found this while debugging an extra reference on the ifa refcount. I think I found a "solution" that isn't quite right, but this comment is misleading.

Revision Contents
Changeset List

Path

Size

sys/

net/

route.c

1 line

Diff 63965

View Options

route: remove an outdated comment from rtrequest1_fibNeeds ReviewPublicActions