Page MenuHomeFreeBSD

route: remove an outdated comment from rtrequest1_fib
Needs ReviewPublic

Authored by jacob.e.keller_intel.com on Nov 5 2019, 5:40 PM.
Tags
None
Referenced Files
F167393114: D22244.id.diff
Fri, Aug 21, 12:46 PM
F167393103: D22244.id.diff
Fri, Aug 21, 12:46 PM
F167393092: D22244.id.diff
Fri, Aug 21, 12:46 PM
Unknown Object (File)
Sun, Aug 2, 3:27 AM
Unknown Object (File)
Thu, Jul 23, 11:44 PM
Unknown Object (File)
Jul 12 2026, 12:36 PM
Unknown Object (File)
Jun 17 2026, 7:18 PM
Unknown Object (File)
Jun 17 2026, 7:18 PM
Subscribers

Details

Reviewers
jhb
mmacy
erj
Summary

revision r334222 modified rtrequest1_fib to always take a reference on
the ifa structure. However, the comment above this indicates the code is
relying on a reference from rt_getifa_fib().

Since this is no longer the case, remove this outdated comment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27358
Build 25608: arc lint + arc unit

Event Timeline

I found this while debugging an extra reference on the ifa refcount. I think I found a "solution" that isn't quite right, but this comment is misleading.