gmultipath: add ATF tests
Add ATF tests for most gmultipath operations. Add some dtrace probes too,
primarily for configuration changes that happen in response to provider
errors.
PR: 178473
Details
Details
- Reviewers
mav - Commits
- rS357876: MFC r355431:
rS355431: gmultipath: add ATF tests
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 27343 Build 25594: arc lint + arc unit
Event Timeline
| tests/sys/geom/class/multipath/misc.sh | ||
|---|---|---|
| 202 | Turns out this test case is invalid. In fact, AFAICT the entire bug was misdiagnosed. gmultipath *does* limit the number of retries at the end of g_multipath_done_error. But my test case *appears* to show a long loop because when dd releases the multipath device, every other geom class gets a chance to taste. You can easily see the correct behavior by setting sysctl kern.geom.notaste=1 (after creating the multipath device). I need to do some more work to determine whether there really is any bug at all. | |
Comment Actions
Fix the failloop test.
There never was a bug to begin with; it only appeared that way due to GEOM
tasting. Now tasting is disabled during the failloop test. That requires
failloop to run exclusively, so it doesn't screw up other tests by disabling
tasting.
Also add a new "restart" dtrace probe. It helps to confirm the nonexistence
of the reported bug.