Make all of the gnop create/configure parameters optional in the kernel,
so that older geom_nop.so userland modules that don't pass some parameters
to the kernel in their request will still work.
Details
Details
I built a version of the geom_nop.so userland module that didn't have any of
the now-optional parameters and verified that the create/configure operations
still work (using default values).
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26981 Build 25281: arc lint + arc unit
Event Timeline
Comment Actions
This seems sane to me...
I'd e tempted to split this into two commits. One for geom_ctl and one for g_nop.
| sys/geom/geom_ctl.c | ||
|---|---|---|
| 388 | I think my previous line comment got lost. This null check isn’t precise enough, because it can also occur when the length check has already failed. In this case the error function is invoked a spurious second time. | |
| sys/geom/geom_ctl.c | ||
|---|---|---|
| 388 | gctl_error() only does anything the first time it is called for a given request, so if it is called here a second time then that won't have any effect. But I can change this to avoid the second call if you'd prefer. | |
| sys/geom/geom_ctl.c | ||
|---|---|---|
| 388 | Oh, ok. I wasn't familiar with the API; it's fine with me to leave it as is. Thanks. | |