Page MenuHomeFreeBSD

amd64: plug spurious cld instructions
ClosedPublic

Authored by mjg on Sat, Oct 5, 5:12 PM.

Details

Summary

ABI already guarantees the direction is forward. Note this does not take care of i386-specific cld's.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjg created this revision.Sat, Oct 5, 5:12 PM
kib added a comment.Sat, Oct 5, 5:36 PM

Why did you left i386 out ?

I do not think it needs cld's as well, both ABI and actual exception/interrupt entry code clear IF.D both on i386 and amd64.

mjg added a comment.Sat, Oct 5, 5:42 PM

i386 has a lot of cld already and I have no means to test the removal. I can plug them from the places modified by this patch though.

mjg updated this revision to Diff 63054.Tue, Oct 8, 9:05 PM
  • drop cld for i386
mjg edited the summary of this revision. (Show Details)Tue, Oct 8, 9:05 PM
kib accepted this revision.Tue, Oct 8, 9:11 PM
This revision is now accepted and ready to land.Tue, Oct 8, 9:11 PM
This revision was automatically updated to reflect the committed changes.