Fix locking for some RACK specific socket options
ClosedPublic
Actions

Authored by tuexen on Sep 27 2019, 7:45 PM.

Tags

None

Referenced Files

	F169932560: D21825.id.diff
	Thu, Sep 3, 12:35 AM

	Unknown Object (File)
	Tue, Sep 1, 2:37 PM

	Unknown Object (File)
	Tue, Sep 1, 12:02 PM

	Unknown Object (File)
	Sun, Aug 30, 12:34 PM

	Unknown Object (File)
	Sun, Aug 30, 8:53 AM

	Unknown Object (File)
	Sun, Aug 30, 8:42 AM

	Unknown Object (File)
	Sun, Aug 30, 8:14 AM

	Unknown Object (File)
	Thu, Aug 27, 12:00 PM

View All Files

Subscribers

imp

Details

Reviewers

rrs

Group Reviewers

transport

Commits

rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt()

Summary

Ensure that the INP lock is released before leaving [gs]etsockopt() for RACK specific socket options.

These issues were found by a syzkaller instance.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 27 2019, 7:45 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 27 2019, 7:45 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B26743: Diff 62665.Sep 27 2019, 7:45 PM

rrs accepted this revision.Sep 28 2019, 9:21 AM

This revision is now accepted and ready to land.Sep 28 2019, 9:21 AM

Closed by commit rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt() (authored by tuexen). · Explain WhySep 28 2019, 1:05 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt().

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

rack.c

13 lines

Diff 62684

View Options

head/sys/netinet/tcp_stacks/rack.c

Fix locking for some RACK specific socket optionsClosedPublicActions