remove obsolete i386 MD memchr implementation
ClosedPublic
Actions

Authored by emaste on Sep 25 2019, 1:59 PM.

Tags

None

Referenced Files

	F166506299: D21785.id62551.diff
	Thu, Aug 13, 8:59 PM

	F166506092: D21785.diff
	Thu, Aug 13, 8:58 PM

	Unknown Object (File)
	Wed, Aug 12, 5:44 AM

	Unknown Object (File)
	Mon, Aug 10, 5:18 AM

	Unknown Object (File)
	Sun, Aug 9, 4:27 PM

	Unknown Object (File)
	Thu, Aug 6, 11:15 PM

	Unknown Object (File)
	Jul 12 2026, 2:57 PM

	Unknown Object (File)
	Jul 4 2026, 8:01 PM

View All Files

Subscribers

imp

Details

Reviewers

markj
kib

Commits

rS352689: remove obsolete i386 MD memchr implementation

Summary

bde reports:

This uses scasb, which was last optimal on the 8086, or perhaps the
original i386.  On freefall, it is several times slower than the
naive translation of the naive C code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Sep 25 2019, 1:59 PM

kib accepted this revision.Sep 25 2019, 2:35 PM

This revision is now accepted and ready to land.Sep 25 2019, 2:35 PM

markj accepted this revision.Sep 25 2019, 2:48 PM

Closed by commit rS352689: remove obsolete i386 MD memchr implementation (authored by emaste). · Explain WhySep 25 2019, 4:49 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS352689: remove obsolete i386 MD memchr implementation.

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2019, 4:49 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

i386/

string/

Makefile.inc

1 line

memchr.S

61 lines

Diff 62551

View Options

head/lib/libc/i386/string/Makefile.inc