Page MenuHomeFreeBSD
Differential D21754

Set NX in mappings created by pmap_kenter() and pmap_kenter_attr().
ClosedPublic
Actions

Authored by markj on Sep 22 2019, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 11:28 AM
Unknown Object (File)
Fri, May 15, 11:28 AM
Unknown Object (File)
Sun, May 10, 2:29 PM
Unknown Object (File)
Tue, Apr 28, 7:17 AM
Unknown Object (File)
Mon, Apr 27, 6:07 AM
Unknown Object (File)
Tue, Apr 21, 9:01 AM
Unknown Object (File)
Mon, Apr 20, 5:19 PM
Unknown Object (File)
Sun, Apr 19, 11:55 PM
View All 93 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr().
Summary

As far as I know there is no reason for such mappings to be executable.
Other functions for creating kernel mappings, such as pmap_qenter(),
also set NX.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sep 22 2019, 7:38 PM
Harbormaster completed remote builds in B26624: Diff 62432.Sep 22 2019, 7:38 PM
markj added reviewers: alc, kib.Sep 22 2019, 7:53 PM
kib accepted this revision.Sep 22 2019, 8:16 PM

I think the only interesting case is pmap_mapbios(), but it should be fine. Anyway, we will see.

This revision is now accepted and ready to land.Sep 22 2019, 8:16 PM
alc accepted this revision.Sep 22 2019, 8:33 PM
Closed by commit rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr(). (authored by markj). · Explain WhySep 23 2019, 2:12 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr()..
Herald added a subscriber: imp. · View Herald TranscriptSep 23 2019, 2:12 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
4 lines

Diff 62465

View Options

head/sys/amd64/amd64/pmap.c

Loading...