Page MenuHomeFreeBSD
Differential D21742

Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1)).
AbandonedPublic
Actions

Authored by ray on Sep 21 2019, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 8:50 AM
Unknown Object (File)
Sat, Apr 6, 8:07 PM
Unknown Object (File)
Sat, Apr 6, 4:02 PM
Unknown Object (File)
Dec 20 2023, 7:57 AM
Unknown Object (File)
Dec 12 2023, 6:26 AM
Unknown Object (File)
Aug 13 2023, 4:59 AM
Unknown Object (File)
Jul 26 2023, 10:53 PM
Unknown Object (File)
Apr 7 2023, 9:27 AM
View All 11 Files
Subscribers
andrew
imp

Details

Reviewers
None
Group Reviewers
ARM
Summary

Seems due some bug in llvm linker 'ALIGN(0x1000) + (. & (0x1000 - 1))'
trick produce kernel with wrong alignment:
[28] .data PROGBITS c0753d00 752d00 06f1d8 00 WA 0 0 64
That breaks boot on early stage with loaders unaware of ELF format.
In my case, kernel can't mach FDT methods on init of OFW.
DATA_SEGMENT_ALIGN special attribute that make job right:
[28] .data PROGBITS c0753000 753000 06f1d8 00 WA 0 0 64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26606
Build 24985: arc lint + arc unit

Event Timeline

ray created this revision.Sep 21 2019, 9:09 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptSep 21 2019, 9:09 PM
Harbormaster completed remote builds in B26606: Diff 62401.Sep 21 2019, 9:09 PM
ray retitled this revision from Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead of ALIGN(0x1000) + (. & (0x1000 - 1)). to Align .data segment with DATA_SEGMENT_ALIGN(0x1000, 0x1000) instead ofALIGN(0x1000) + (. & (0x1000 - 1))..Sep 21 2019, 9:10 PM
ray added a reviewer: ARM.
ray abandoned this revision.Sep 25 2019, 12:40 PM

It is wrong way to fix elfcopy bug.
Thanks to @strejda for pointing that.

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines

Diff 62401

View Options

sys/conf/ldscript.arm

Loading...