Page MenuHomeFreeBSD
Differential D21651

TPM2-ABRMD
ClosedPublic
Actions

Authored by tadeusz.struk_intel.com on Sep 13 2019, 10:03 PM.

Details

Reviewers
lwhsu
Commits
rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon
Summary

Add TPM2 Access Broker & Resource Manager Daemon

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tadeusz.struk_intel.com created this revision.Sep 13 2019, 10:03 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptSep 13 2019, 10:03 PM
lwhsu added a subscriber: lwhsu.Sep 13 2019, 11:35 PM
lwhsu added inline comments.Sep 13 2019, 11:54 PM
security/tpm2-abrmd/Makefile
15 ↗(On Diff #62073)

Just a minor portlint(1) nit, no blank line needed here.

tadeusz.struk_intel.com updated this revision to Diff 62080.Sep 14 2019, 1:21 AM
tadeusz.struk_intel.com marked an inline comment as done.

Reworked according to feedback

lwhsu added inline comments.Sep 14 2019, 8:08 AM
security/tpm2-abrmd/Makefile
22 ↗(On Diff #62080)

Do we really need this line? I can build the port without this. (+= is usually not necessary before including anything.)

lwhsu added a reviewer: lwhsu.Sep 14 2019, 8:09 AM
tadeusz.struk_intel.com marked an inline comment as done.Sep 14 2019, 1:54 PM
tadeusz.struk_intel.com added inline comments.
security/tpm2-abrmd/Makefile
22 ↗(On Diff #62080)

I followed an example, but probably the LIB_DEPENDS does the job.

tadeusz.struk_intel.com updated this revision to Diff 62094.Sep 14 2019, 1:55 PM
tadeusz.struk_intel.com marked an inline comment as done.

Removed unneeded LIBS+= line

lwhsu accepted this revision.Sep 14 2019, 2:12 PM

Thanks. Please also consider to upstream the patches to ease the future updates.

This revision is now accepted and ready to land.Sep 14 2019, 2:12 PM
lwhsu mentioned this in D21649: TPM2-TSS.Sep 17 2019, 9:38 AM
Closed by commit rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon (authored by lwhsu). · Explain WhySep 17 2019, 7:58 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon.

Revision Contents
Changeset List

PathSize
head/
security/
1 line
tpm2-abrmd/
40 lines
3 lines
files/
11 lines
18 lines
20 lines
26 lines
3 lines
11 lines

Diff 62231

View Options

head/security/Makefile

Loading...
View Options

head/security/tpm2-abrmd/Makefile

Loading...
View Options

head/security/tpm2-abrmd/distinfo

Loading...
View Options

head/security/tpm2-abrmd/files/patch-dist_tpm2-abrmd.conf

Loading...
View Options

head/security/tpm2-abrmd/files/patch-src_tpm2-header.c

Loading...
View Options

head/security/tpm2-abrmd/files/patch-src_util.h

Loading...
View Options

head/security/tpm2-abrmd/files/tpm2-abrmd.in

Loading...
View Options

head/security/tpm2-abrmd/pkg-descr

Loading...
View Options

head/security/tpm2-abrmd/pkg-plist

Loading...