Differential D21651

TPM2-ABRMD
ClosedPublic
Actions

Authored by tadeusz.struk_intel.com on Sep 13 2019, 10:03 PM.

Tags

None

Subscribers

lwhsu, mat, Contributor Reviewers (ports)

Details

Reviewers

Commits

rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon

Summary

Add TPM2 Access Broker & Resource Manager Daemon

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tadeusz.struk_intel.com created this revision.Sep 13 2019, 10:03 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptSep 13 2019, 10:03 PM

lwhsu added a subscriber: lwhsu.Sep 13 2019, 11:35 PM

lwhsu added inline comments.Sep 13 2019, 11:54 PM

security/tpm2-abrmd/Makefile
15 ↗	(On Diff #62073)	Just a minor portlint(1) nit, no blank line needed here.

Reworked according to feedback

lwhsu added inline comments.Sep 14 2019, 8:08 AM

security/tpm2-abrmd/Makefile
22 ↗	(On Diff #62080)	Do we really need this line? I can build the port without this. (`+=` is usually not necessary before including anything.)

lwhsu added a reviewer: lwhsu.Sep 14 2019, 8:09 AM

tadeusz.struk_intel.com marked an inline comment as done.Sep 14 2019, 1:54 PM

tadeusz.struk_intel.com added inline comments.

security/tpm2-abrmd/Makefile
22 ↗	(On Diff #62080)	I followed an example, but probably the LIB_DEPENDS does the job.

Removed unneeded LIBS+= line

Thanks. Please also consider to upstream the patches to ease the future updates.

This revision is now accepted and ready to land.Sep 14 2019, 2:12 PM

lwhsu mentioned this in D21649: TPM2-TSS.Sep 17 2019, 9:38 AM

Closed by commit rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon (authored by lwhsu). · Explain WhySep 17 2019, 7:58 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rP512239: Add security/tpm2-abrmd, TPM2 Access Broker & Resource Manager Deamon.

Revision Contents
Changeset List

			Path	Packages
M			head/security/Makefile (1 line)
M	M		head/security/tpm2-abrmd/Makefile (40 lines)
M	M		head/security/tpm2-abrmd/distinfo (3 lines)
M	M		head/security/tpm2-abrmd/files/patch-dist_tpm2-abrmd.conf (11 lines)
M	M		head/security/tpm2-abrmd/files/patch-src_tpm2-header.c (18 lines)
M	M		head/security/tpm2-abrmd/files/patch-src_util.h (20 lines)
M	M		head/security/tpm2-abrmd/files/tpm2-abrmd.in (26 lines)
M	M		head/security/tpm2-abrmd/pkg-descr (3 lines)
M	M		head/security/tpm2-abrmd/pkg-plist (11 lines)

Diff 62231

head/security/Makefile

Loading...

head/security/tpm2-abrmd/Makefile

Loading...

head/security/tpm2-abrmd/distinfo

Loading...

head/security/tpm2-abrmd/files/patch-dist_tpm2-abrmd.conf

Loading...

head/security/tpm2-abrmd/files/patch-src_tpm2-header.c

Loading...

head/security/tpm2-abrmd/files/patch-src_util.h

Loading...

head/security/tpm2-abrmd/files/tpm2-abrmd.in

Loading...

head/security/tpm2-abrmd/pkg-descr

Loading...

head/security/tpm2-abrmd/pkg-plist

Loading...