Page MenuHomeFreeBSD

TPM2-ABRMD
ClosedPublic

Authored by tadeusz.struk_intel.com on Sep 13 2019, 10:03 PM.

Details

Summary

Add TPM2 Access Broker & Resource Manager Daemon

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lwhsu added a subscriber: lwhsu.Sep 13 2019, 11:35 PM
lwhsu added inline comments.Sep 13 2019, 11:54 PM
security/tpm2-abrmd/Makefile
15 ↗(On Diff #62073)

Just a minor portlint(1) nit, no blank line needed here.

tadeusz.struk_intel.com marked an inline comment as done.

Reworked according to feedback

lwhsu added inline comments.Sep 14 2019, 8:08 AM
security/tpm2-abrmd/Makefile
22 ↗(On Diff #62080)

Do we really need this line? I can build the port without this. (+= is usually not necessary before including anything.)

lwhsu added a reviewer: lwhsu.Sep 14 2019, 8:09 AM
tadeusz.struk_intel.com marked an inline comment as done.Sep 14 2019, 1:54 PM
tadeusz.struk_intel.com added inline comments.
security/tpm2-abrmd/Makefile
22 ↗(On Diff #62080)

I followed an example, but probably the LIB_DEPENDS does the job.

tadeusz.struk_intel.com marked an inline comment as done.

Removed unneeded LIBS+= line

lwhsu accepted this revision.Sep 14 2019, 2:12 PM

Thanks. Please also consider to upstream the patches to ease the future updates.

This revision is now accepted and ready to land.Sep 14 2019, 2:12 PM