Page MenuHomeFreeBSD
Differential D21632

realloc(x, 0) should not return NULL
ClosedPublic
Actions

Authored by kib on Sep 13 2019, 9:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 8, 3:07 AM
Unknown Object (File)
Fri, May 8, 2:38 AM
Unknown Object (File)
Fri, May 8, 12:46 AM
Unknown Object (File)
Thu, May 7, 9:49 AM
Unknown Object (File)
Wed, May 6, 8:47 AM
Unknown Object (File)
Sat, May 2, 10:58 PM
Unknown Object (File)
Wed, Apr 29, 11:33 AM
Unknown Object (File)
Wed, Apr 29, 11:28 AM
View All Files
Subscribers
imp
jilles

Details

Reviewers
emaste
Commits
rS352456: realloc(x, 0) should not return NULL.
Summary

See http://www.open-std.org/jtc1/sc22/wg14/www/docs/summary.htm#dr_400

PR: 240456

[No idea how to upstream this]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Sep 13 2019, 9:21 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2019, 9:21 AM
Harbormaster completed remote builds in B26458: Diff 62024.Sep 13 2019, 9:21 AM
emaste added a subscriber: jilles.Sep 16 2019, 4:23 PM
emaste accepted this revision.Sep 16 2019, 4:27 PM
emaste added inline comments.
contrib/jemalloc/src/jemalloc.c
2301 ↗(On Diff #62024)

looks like local style here has braces on single-line statements

This revision is now accepted and ready to land.Sep 16 2019, 4:27 PM
emaste added a comment.Sep 16 2019, 4:29 PM

For upstreaming a pull request against https://github.com/jemalloc/jemalloc presumably

emaste added a comment.Sep 16 2019, 4:36 PM

I opened an upstream issue at https://github.com/jemalloc/jemalloc/issues/1629

Closed by commit rS352456: realloc(x, 0) should not return NULL. (authored by kib). · Explain WhySep 17 2019, 6:36 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS352456: realloc(x, 0) should not return NULL..

Revision Contents
Changeset List

PathSize
head/
contrib/
jemalloc/
src/
15 lines

Diff 62220

View Options

head/contrib/jemalloc/src/jemalloc.c

Loading...