Page MenuHomeFreeBSD
Differential D21631

powerpc/powernv: Add OPAL NVRAM driver
ClosedPublic
Actions

Authored by jhibbits on Sep 13 2019, 3:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 12:59 AM
Unknown Object (File)
Nov 10 2023, 5:49 AM
Unknown Object (File)
Nov 7 2023, 1:21 AM
Unknown Object (File)
Oct 9 2023, 4:45 AM
Unknown Object (File)
Oct 6 2023, 12:23 AM
Unknown Object (File)
Sep 17 2023, 1:04 PM
Unknown Object (File)
May 14 2023, 6:37 PM
Unknown Object (File)
Apr 25 2023, 6:56 PM
View All 10 Files
Subscribers
None

Details

Reviewers
luporl
bdragon
nwhitehorn
Summary

Add a very basic OPAL NVRAM driver, which can be used by the IBM
power-utils toolkit for reading and writing NVRAM on powernv systems.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26453
Build 24884: arc lint + arc unit

Event Timeline

jhibbits created this revision.Sep 13 2019, 3:11 AM
Harbormaster completed remote builds in B26453: Diff 62017.Sep 13 2019, 3:11 AM
luporl accepted this revision.Sep 13 2019, 7:47 PM

LGTM.

sys/powerpc/powernv/opal_nvram.c
148

Isn't a NULL check of contigmalloc() return value needed here?

This revision is now accepted and ready to land.Sep 13 2019, 7:47 PM
jhibbits added inline comments.Sep 13 2019, 8:22 PM
sys/powerpc/powernv/opal_nvram.c
148

You're right. Even though I specify M_WAITOK, from code inspection it only allows me 3 retries before it gives up and returns NULL.

jhibbits closed this revision.Sep 14 2019, 4:06 AM

r352313

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
modules/
3 lines
opal_nvram/
10 lines
powerpc/
powernv/
2 lines
272 lines

Diff 62017

View Options

sys/conf/files.powerpc

Loading...
View Options

sys/modules/Makefile

Loading...
View Options

sys/modules/opal_nvram/Makefile

Loading...
View Options

sys/powerpc/powernv/opal.h

Loading...
View Options

sys/powerpc/powernv/opal_nvram.c

Loading...