Page MenuHomeFreeBSD

fusefs: fix some minor issues with fuse_vnode_setparent
ClosedPublic

Authored by asomers on Sep 13 2019, 1:53 AM.

Details

Summary

fusefs: fix some minor issues with fuse_vnode_setparent

  • When unparenting a vnode, actually clear the flag. AFAIK this is basically a no-op because we only unparent a vnode when reclaiming it or when unlinking.
  • There's no need to call fuse_vnode_setparent during reclaim, because we're about to free the vnode data anyway.
Test Plan

Ran the builtin test suite and pjdfstest

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Sep 13 2019, 1:53 AM
emaste accepted this revision.Sep 16 2019, 1:53 PM

I'm not an expert here but seems reasonable.

This revision is now accepted and ready to land.Sep 16 2019, 1:53 PM
This revision was automatically updated to reflect the committed changes.