Use REFCOUNT_COUNT() to obtain refcount where appropriate
ClosedPublic
Actions

Authored by • hselasky on Sep 12 2019, 3:46 PM.

Details

Reviewers

markj
kib

Commits

rS352253: Use REFCOUNT_COUNT() to obtain refcount where appropriate.

Summary

Refcount waiting will set some flag bits in the refcount value. Make sure these bits get cleared by using the REFCOUNT_COUNT() macro to obtain the actual refcount.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• hselasky created this revision.Sep 12 2019, 3:46 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 12 2019, 3:46 PM

Harbormaster completed remote builds in B26427: Diff 61982.Sep 12 2019, 3:46 PM

kib accepted this revision.Sep 12 2019, 3:48 PM

kib added inline comments.

sys/vm/vm_object.c
398 ↗	(On Diff #61982)	Fix the style, `... > 0`. There and several places below as well.

This revision is now accepted and ready to land.Sep 12 2019, 3:48 PM

Fix style.

This revision now requires review to proceed.Sep 12 2019, 4:06 PM

Harbormaster completed remote builds in B26430: Diff 61985.Sep 12 2019, 4:06 PM

Does this fix an observed bug? The waiter bit should only be set if the counter value is non-zero, so the comparisons with 0 should work correctly regardless. I agree with the change though.

This revision is now accepted and ready to land.Sep 12 2019, 4:08 PM

There is no observed bug.

Closed by commit rS352253: Use REFCOUNT_COUNT() to obtain refcount where appropriate. (authored by • hselasky). · Explain WhySep 12 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS352253: Use REFCOUNT_COUNT() to obtain refcount where appropriate..