Differential D21530

Fix ggate.h typo.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Sep 5 2019, 4:25 AM.

Tags

None

Referenced Files

	F102706868: D21530.id.diff
	Sat, Nov 16, 3:38 AM

	Unknown Object (File)
	Mon, Oct 28, 11:16 PM

	Unknown Object (File)
	Oct 15 2024, 2:52 AM

	Unknown Object (File)
	Oct 3 2024, 9:49 AM

	Unknown Object (File)
	Sep 24 2024, 9:09 PM

	Unknown Object (File)
	Sep 24 2024, 9:09 PM

	Unknown Object (File)
	Sep 24 2024, 9:09 PM

	Unknown Object (File)
	Sep 22 2024, 9:49 PM

View All 50 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

pjd
delphij

Commits

rS351936: Fix typo not -> nor and add 'the' because we are talking about specific flags

Summary

A not B -> A nor B

Test Plan

buildworld.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ota_j.email.ne.jp created this revision.Sep 5 2019, 4:25 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptSep 5 2019, 4:25 AM

Harbormaster completed remote builds in B26284: Diff 61666.Sep 5 2019, 4:25 AM

ota_j.email.ne.jp added reviewers: pjd, delphij.Sep 6 2019, 4:06 AM

imp added inline comments.Sep 6 2019, 4:15 AM

sbin/ggate/shared/ggate.h
50 ↗	(On Diff #61666)	"If neither the GGATE_FLAG_SEND nor the GGATE_FLAG_RECV flags are set, this is the initial connection." is how I'd write this sentence....

imp added inline comments.Sep 6 2019, 2:19 PM

sbin/ggate/shared/ggate.h
50 ↗	(On Diff #61666)	"If neither the GGATE_FLAG_SEND nor the GGATE_FLAG_RECV flag is set, this is the initial connection." My former english professor wife says it should be singular.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2019, 3:02 PM

Closed by commit rS351936: Fix typo not -> nor and add 'the' because we are talking about specific flags (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS351936: Fix typo not -> nor and add 'the' because we are talking about specific flags.

Thanks.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ggate/

shared/

4 lines

Diff 61736

head/sbin/ggate/shared/ggate.h

Loading...