Differential D21487

mips: ubldr: use truncated load address for mips32
ClosedPublic
Actions

Authored by kevans on Sep 2 2019, 2:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 18, 11:01 PM

	Unknown Object (File)
	Sat, Oct 18, 7:52 PM

	Unknown Object (File)
	Fri, Oct 17, 11:18 AM

	Unknown Object (File)
	Thu, Oct 16, 6:19 PM

	Unknown Object (File)
	Thu, Oct 16, 5:41 PM

	Unknown Object (File)
	Thu, Oct 16, 9:33 AM

	Unknown Object (File)
	Thu, Oct 9, 8:11 PM

	Unknown Object (File)
	Sep 21 2025, 8:20 AM

Subscribers

Details

Reviewers

imp
emaste
mizhka

Commits

rS352464: mips: ubldr: use truncated load address for mips32

Summary

BFD appears to silently truncate 0xffffffff80800000 when it processes the ldscript for 32-bit mips, but LLD chokes on it as the linker script tries to place elements above 32-bit range. It's unclear to me if silent truncation is kosher or not and whether this patch is really what we want to do, but it is one approach at least.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 2 2019, 2:12 AM

Harbormaster completed remote builds in B26224: Diff 61541.Sep 2 2019, 2:12 AM

Seems not at all right to me...

stand/mips/uboot/Makefile
22 ↗	(On Diff #61541)	this is a nop for mipsel machines.

In D21487#467962, @imp wrote:

Seems not at all right to me...

Yeah...

stand/mips/uboot/Makefile
22 ↗	(On Diff #61541)	Whoops, should have gone for :Mmips64* otherwise use truncated default...

imp added inline comments.Sep 2 2019, 1:48 PM

stand/mips/uboot/Makefile
22 ↗	(On Diff #61541)	Yea, either way... There's no good way to define predicates in make :(

Correct test sense

Harbormaster completed remote builds in B26228: Diff 61555.Sep 2 2019, 3:55 PM

I fear this is the last bad choice we have.

This revision is now accepted and ready to land.Sep 11 2019, 1:18 AM

LGTM

Closed by commit rS352464: mips: ubldr: use truncated load address for mips32 (authored by kevans). · Explain WhySep 18 2019, 1:33 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS352464: mips: ubldr: use truncated load address for mips32.

Revision Contents
Changeset List

Path

Size

head/

stand/

mips/

uboot/

4 lines

Diff 62244

head/stand/mips/uboot/Makefile

Loading...