Page MenuHomeFreeBSD

cpuset_setdomain(2): Ensure that the set is a subset of all_domains.
ClosedPublic

Authored by markj on Aug 30 2019, 8:24 PM.
Tags
None
Referenced Files
F162734611: D21477.diff
Thu, Jul 16, 7:36 AM
Unknown Object (File)
Thu, Jul 2, 9:22 PM
Unknown Object (File)
Thu, Jul 2, 3:08 PM
Unknown Object (File)
May 11 2026, 10:33 AM
Unknown Object (File)
May 10 2026, 2:13 PM
Unknown Object (File)
May 3 2026, 6:45 PM
Unknown Object (File)
Apr 21 2026, 8:11 PM
Unknown Object (File)
Apr 21 2026, 8:12 AM
Subscribers

Details

Summary

Userspace is allowed to provide a mask of up to 256 bits. In the
kernel, the domain mask is 64 bits wide even though MAXMEMDOM is 8.
cpuset_setdomain() returns EINVAL if any bits beyond the first 64 are
set; go further and return an error if any bits outside of
all_domains are set.

domainset_empty_vm() assumes that the input set is a subset of
all_domains, since it iterates over the set and populates the ds_order
table. The problem became more noticeable after r351547.

We could instead silently mask off bits that are not present in
all_domains. However, since we already check for domain IDs >= 64
and return EINVAL if any are present, I don't see why we should
be inconsistent for domain IDs < 64.

Test Plan

Peter reported the bug and tested an earlier version of the patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable