Page MenuHomeFreeBSD

cpuset_setdomain(2): Ensure that the set is a subset of all_domains.
ClosedPublic

Authored by markj on Aug 30 2019, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 27, 8:19 PM
Unknown Object (File)
Wed, Aug 26, 3:41 PM
Unknown Object (File)
Tue, Aug 25, 10:06 AM
Unknown Object (File)
Mon, Aug 24, 6:49 PM
Unknown Object (File)
Sun, Aug 23, 10:41 AM
Unknown Object (File)
Sat, Aug 22, 7:17 PM
Unknown Object (File)
Sat, Aug 22, 10:12 AM
Unknown Object (File)
Sat, Aug 15, 3:00 AM
Subscribers

Details

Summary

Userspace is allowed to provide a mask of up to 256 bits. In the
kernel, the domain mask is 64 bits wide even though MAXMEMDOM is 8.
cpuset_setdomain() returns EINVAL if any bits beyond the first 64 are
set; go further and return an error if any bits outside of
all_domains are set.

domainset_empty_vm() assumes that the input set is a subset of
all_domains, since it iterates over the set and populates the ds_order
table. The problem became more noticeable after r351547.

We could instead silently mask off bits that are not present in
all_domains. However, since we already check for domain IDs >= 64
and return EINVAL if any are present, I don't see why we should
be inconsistent for domain IDs < 64.

Test Plan

Peter reported the bug and tested an earlier version of the patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable