Page MenuHomeFreeBSD
Differential D21466

Coverity fixes in fusefs(5)
ClosedPublic
Actions

Authored by asomers on Aug 29 2019, 5:06 PM.
Tags
None
Referenced Files
F165776175: D21466.id61760.diff
Sun, Aug 9, 6:55 PM
F165750148: D21466.id61459.diff
Sun, Aug 9, 3:43 PM
Unknown Object (File)
Sun, Aug 9, 2:50 PM
Unknown Object (File)
Mon, Jul 27, 1:15 PM
Unknown Object (File)
Fri, Jul 24, 6:05 PM
Unknown Object (File)
Fri, Jul 24, 1:28 PM
Unknown Object (File)
Wed, Jul 22, 10:15 AM
Unknown Object (File)
Tue, Jul 21, 1:28 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
cem
emaste
Commits
rS351961: Coverity fixes in fusefs(5)
Summary

Coverity fixes in fusefs(5)

CID 1404532 fixes a signed vs unsigned comparison error in fuse_vnop_bmap.
It could potentially have resulted in VOP_BMAP reporting too many
consecutive blocks.

CID 1404364 is much worse. It was an array access by an untrusted,
user-provided variable. It could potentially have resulted in a malicious
file system crashing the kernel or worse.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Aug 29 2019, 5:06 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2019, 5:06 PM
Harbormaster completed remote builds in B26181: Diff 61459.Aug 29 2019, 5:06 PM
emaste accepted this revision.Sep 6 2019, 2:26 PM
emaste added a subscriber: emaste.
emaste added inline comments.
sys/fs/fuse/fuse_internal.c
393 ↗(On Diff #61459)

namelen includes the '\0' presumably

This revision is now accepted and ready to land.Sep 6 2019, 2:26 PM
Closed by commit rS351961: Coverity fixes in fusefs(5) (authored by asomers). · Explain WhySep 6 2019, 7:40 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS351961: Coverity fixes in fusefs(5).
asomers mentioned this in rS352351: MFC the new fusefs driver.Sep 15 2019, 4:15 AM

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
fuse/
3 lines
2 lines

Diff 61760

View Options

head/sys/fs/fuse/fuse_internal.c

Loading...
View Options

head/sys/fs/fuse/fuse_vnops.c

Loading...