Page MenuHomeFreeBSD

Coverity fixes in fusefs(5)
ClosedPublic

Authored by asomers on Aug 29 2019, 5:06 PM.

Details

Summary

Coverity fixes in fusefs(5)

CID 1404532 fixes a signed vs unsigned comparison error in fuse_vnop_bmap.
It could potentially have resulted in VOP_BMAP reporting too many
consecutive blocks.

CID 1404364 is much worse. It was an array access by an untrusted,
user-provided variable. It could potentially have resulted in a malicious
file system crashing the kernel or worse.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Aug 29 2019, 5:06 PM
emaste accepted this revision.Sep 6 2019, 2:26 PM
emaste added a subscriber: emaste.
emaste added inline comments.
sys/fs/fuse/fuse_internal.c
393 ↗(On Diff #61459)

namelen includes the '\0' presumably

This revision is now accepted and ready to land.Sep 6 2019, 2:26 PM
This revision was automatically updated to reflect the committed changes.