Linuxulator. struct rusage conversion (0).
ClosedPublic
Actions

Authored by dchagin on Mar 25 2015, 4:38 PM.

Details

Reviewers

emaste
trasz

Commits

rS283391: To reduce code duplication introduce linux_copyout_rusage() method.

Summary

To reduce code duplication introduce linux_copyout_rusage method. Use it in linux_wait4() system call and move linux_wait4() to the MI path. While here add a prototype for the static bsd_to_linux_rusage().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 4403.Mar 25 2015, 4:38 PM

dchagin retitled this revision from to Linuxulator. struct rusage conversion (0)..

dchagin updated this object.

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2015, 4:38 PM

dchagin added reviewers: trasz, emaste.Mar 25 2015, 4:43 PM

trasz added inline comments.Mar 27 2015, 9:36 AM

sys/amd64/linux32/linux.h
783 ↗	(On Diff #4403)	const struct rusage *ru? Same below.
sys/i386/linux/linux.h
744 ↗	(On Diff #4403)	Is this because the Linux struct rusage is exactly the same as the FreeBSD one for i386? If so, a comment that says it would be nice. (To be honest I'd prefer l_rusage being defined for both architectures and bsd_to_linux_rusage() simply do a copy, but it's just nitpicking; current way works too.)