Page MenuHomeFreeBSD
Differential D21364

ping: do numeric-only output by default
ClosedPublic
Actions

Authored by jansucan on Aug 22 2019, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 5:31 PM
Unknown Object (File)
Thu, Nov 20, 5:25 PM
Unknown Object (File)
Thu, Nov 20, 5:23 PM
Unknown Object (File)
Thu, Nov 20, 5:23 PM
Unknown Object (File)
Thu, Nov 20, 5:14 PM
Unknown Object (File)
Mon, Nov 17, 4:29 PM
Unknown Object (File)
Tue, Nov 11, 1:43 AM
Unknown Object (File)
Sun, Nov 9, 11:39 PM
View All Files
Subscribers
imp

Details

Reviewers
asomers
Group Reviewers
manpages
Commits
rS351398: ping: By default, don't reverse lookup IP addresses
Summary

Do numeric-only output by default

Now both ping and ping6 do numeric-only output by default.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google LLC (Google Summer of Code 2019)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26015
Build 24563: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 22 2019, 8:42 AM
Harbormaster completed remote builds in B26009: Diff 61111.Aug 22 2019, 8:43 AM
asomers requested changes to this revision.Aug 22 2019, 3:34 PM
asomers added inline comments.
sbin/ping/ping.8
162–163

Needs an article here: "This is the opposite of the"

This revision now requires changes to proceed.Aug 22 2019, 3:34 PM
jansucan updated this revision to Diff 61124.Aug 22 2019, 6:26 PM

Add an article in the manual page.

Harbormaster completed remote builds in B26015: Diff 61124.Aug 22 2019, 6:26 PM
jansucan added inline comments.Aug 22 2019, 6:27 PM
sbin/ping/ping.8
162–163

Fixed.

asomers accepted this revision.Aug 22 2019, 6:53 PM
This revision is now accepted and ready to land.Aug 22 2019, 6:53 PM
Closed by commit rS351398: ping: By default, don't reverse lookup IP addresses (authored by asomers). · Explain WhyAug 22 2019, 6:57 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS351398: ping: By default, don't reverse lookup IP addresses.
Herald added a reviewer: manpages. · View Herald TranscriptAug 22 2019, 6:57 PM
Herald added a subscriber: imp. · View Herald Transcript
jansucan mentioned this in D21338: ping6: make lookup of symbolic names in the reply default.Aug 23 2019, 6:22 AM
asomers mentioned this in rS352371: MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226….Sep 16 2019, 12:57 AM

Revision Contents
Changeset List

PathSize
sbin/
ping/
13 lines
2 lines
tests/
2 lines

Diff 61124

View Options

sbin/ping/ping.8

Loading...
View Options

sbin/ping/ping.c

Loading...
View Options

sbin/ping/tests/ping_c1_s56_t1.out

Loading...