Don't set the string "unknown" as a device's location_str
ClosedPublic
Actions

Authored by scottph on Aug 19 2019, 5:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 30, 9:18 AM

	Unknown Object (File)
	Fri, Nov 28, 6:36 AM

	Unknown Object (File)
	Thu, Nov 20, 3:24 PM

	Unknown Object (File)
	Thu, Nov 20, 3:24 PM

	Unknown Object (File)
	Thu, Nov 20, 3:23 PM

	Unknown Object (File)
	Thu, Nov 20, 3:14 PM

	Unknown Object (File)
	Oct 22 2025, 12:01 PM

	Unknown Object (File)
	Oct 22 2025, 12:01 PM

View All 74 Files

Subscribers

None

Details

Reviewers

imp
jhb
emaste

Commits

rS351225: Don't set the string "unknown" as a device's location_str

Summary

Return an empty string when the location is unknown instead of the
string "unknown". This ensures that all location entries are of
the form key=val.

Suggested by: imp
MFC after: 1 week
Sponsored by: Intel Corporation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

scottph created this revision.Aug 19 2019, 5:10 PM

jhb accepted this revision.Aug 19 2019, 5:15 PM

This revision is now accepted and ready to land.Aug 19 2019, 5:15 PM

Closed by commit rS351225: Don't set the string "unknown" as a device's location_str (authored by scottph). · Explain WhyAug 19 2019, 5:51 PM

This revision was automatically updated to reflect the committed changes.

scottph added a commit: rS351225: Don't set the string "unknown" as a device's location_str.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

acpica/

acpi.c

2 lines

nvdimm/

nvdimm.c

2 lines

Diff 61007

View Options

head/sys/dev/acpica/acpi.c